fix: proper error message display

This commit is contained in:
Louis 2024-11-28 13:23:03 +07:00
parent 2e35b2f20d
commit 19c6a26ef5
No known key found for this signature in database
GPG Key ID: 44FA9F4D33C37DE2
2 changed files with 35 additions and 14 deletions

View File

@ -61,16 +61,12 @@ const ChatBody = memo(
<ListContainer> <ListContainer>
{messages.map((message, index) => ( {messages.map((message, index) => (
<div key={message.id}> <div key={message.id}>
{message.status !== MessageStatus.Error && ( <ChatItem
<ChatItem {...message} key={message.id} /> {...message}
)} key={message.id}
loadModelError={loadModelError}
{!loadModelError && isCurrentMessage={index === messages.length - 1}
index === messages.length - 1 && />
message.status !== MessageStatus.Pending &&
message.status !== MessageStatus.Ready && (
<ErrorMessage message={message} />
)}
</div> </div>
))} ))}

View File

@ -8,21 +8,39 @@ import {
ThreadMessage, ThreadMessage,
} from '@janhq/core' } from '@janhq/core'
import ErrorMessage from '@/containers/ErrorMessage'
import SimpleTextMessage from '../SimpleTextMessage' import SimpleTextMessage from '../SimpleTextMessage'
type Ref = HTMLDivElement type Ref = HTMLDivElement
const ChatItem = forwardRef<Ref, ThreadMessage>((message, ref) => { type Props = {
loadModelError?: string
isCurrentMessage?: boolean
} & ThreadMessage
const ChatItem = forwardRef<Ref, Props>((message, ref) => {
const [content, setContent] = useState<ThreadContent[]>(message.content) const [content, setContent] = useState<ThreadContent[]>(message.content)
const [status, setStatus] = useState<MessageStatus>(message.status) const [status, setStatus] = useState<MessageStatus>(message.status)
const [errorMessage, setErrorMessage] = useState<ThreadMessage | undefined>(
message.isCurrentMessage && message.status === MessageStatus.Error
? message
: undefined
)
function onMessageUpdate(data: ThreadMessage) { function onMessageUpdate(data: ThreadMessage) {
if (data.id === message.id) { if (data.id === message.id) {
setContent(data.content) setContent(data.content)
if (data.status !== status) setStatus(data.status) if (data.status !== status) setStatus(data.status)
if (data.status === MessageStatus.Error && message.isCurrentMessage)
setErrorMessage(data)
} }
} }
useEffect(() => {
if (!message.isCurrentMessage && errorMessage) setErrorMessage(undefined)
}, [message, errorMessage])
useEffect(() => { useEffect(() => {
if (message.status === MessageStatus.Pending) if (message.status === MessageStatus.Pending)
events.on(MessageEvent.OnMessageUpdate, onMessageUpdate) events.on(MessageEvent.OnMessageUpdate, onMessageUpdate)
@ -33,9 +51,16 @@ const ChatItem = forwardRef<Ref, ThreadMessage>((message, ref) => {
}, []) }, [])
return ( return (
<>
{status !== MessageStatus.Error && content.length > 0 && (
<div ref={ref} className="relative"> <div ref={ref} className="relative">
<SimpleTextMessage {...message} content={content} status={status} /> <SimpleTextMessage {...message} content={content} status={status} />
</div> </div>
)}
{errorMessage && !message.loadModelError && (
<ErrorMessage message={errorMessage} />
)}
</>
) )
}) })