From 2744e787d1de865ef1b86c0464cb83af05a56926 Mon Sep 17 00:00:00 2001 From: Nguyen Ngoc Minh <91668012+Minh141120@users.noreply.github.com> Date: Mon, 26 May 2025 16:04:43 +0800 Subject: [PATCH] fix: ci remove pr review trigger (#5105) * fix: remove pull_request_review trigger to avoid redundant builds * chore: comment out pr-build-url job in nightly workflow --- .../workflows/jan-electron-build-nightly.yml | 50 +++++++++---------- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/.github/workflows/jan-electron-build-nightly.yml b/.github/workflows/jan-electron-build-nightly.yml index 88776903b..b4d275658 100644 --- a/.github/workflows/jan-electron-build-nightly.yml +++ b/.github/workflows/jan-electron-build-nightly.yml @@ -12,8 +12,6 @@ on: - none - aws-s3 default: none - pull_request_review: - types: [submitted] pull_request: branches: - release/** @@ -190,28 +188,28 @@ jobs: new_version: ${{ needs.get-update-version.outputs.new_version }} - comment-pr-build-url: - needs: [ - build-tauri-macos, - build-tauri-windows-x64, - build-tauri-linux-x64, - get-update-version, - set-public-provider, - sync-temp-to-latest - ] - runs-on: ubuntu-latest - if: github.event_name == 'pull_request_review' - steps: - - name: Set up GitHub CLI - run: | - curl -sSL https://github.com/cli/cli/releases/download/v2.33.0/gh_2.33.0_linux_amd64.tar.gz | tar xz - sudo cp gh_2.33.0_linux_amd64/bin/gh /usr/local/bin/ + # comment-pr-build-url: + # needs: [ + # build-tauri-macos, + # build-tauri-windows-x64, + # build-tauri-linux-x64, + # get-update-version, + # set-public-provider, + # sync-temp-to-latest + # ] + # runs-on: ubuntu-latest + # if: github.event_name == 'pull_request_review' + # steps: + # - name: Set up GitHub CLI + # run: | + # curl -sSL https://github.com/cli/cli/releases/download/v2.33.0/gh_2.33.0_linux_amd64.tar.gz | tar xz + # sudo cp gh_2.33.0_linux_amd64/bin/gh /usr/local/bin/ - - name: Comment build URL on PR - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: | - PR_URL=${{ github.event.pull_request.html_url }} - RUN_ID=${{ github.run_id }} - COMMENT="This is the build for this pull request. You can download it from the Artifacts section here: [Build URL](https://github.com/${{ github.repository }}/actions/runs/${RUN_ID})." - gh pr comment $PR_URL --body "$COMMENT" \ No newline at end of file + # - name: Comment build URL on PR + # env: + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # run: | + # PR_URL=${{ github.event.pull_request.html_url }} + # RUN_ID=${{ github.run_id }} + # COMMENT="This is the build for this pull request. You can download it from the Artifacts section here: [Build URL](https://github.com/${{ github.repository }}/actions/runs/${RUN_ID})." + # gh pr comment $PR_URL --body "$COMMENT" \ No newline at end of file