fix: prevent stale provider model requests from polluting UI state
This commit is contained in:
parent
70bf257e75
commit
3d0ce15fe8
@ -95,6 +95,7 @@ export const DialogAddModel = ({ provider, trigger }: DialogAddModelProps) => {
|
||||
<span className="text-destructive">*</span>
|
||||
</label>
|
||||
<ModelCombobox
|
||||
key={`${provider.provider}-${provider.base_url || ''}`}
|
||||
value={modelId}
|
||||
onChange={setModelId}
|
||||
models={models}
|
||||
|
||||
@ -16,6 +16,7 @@ export const useProviderModels = (provider?: ModelProvider): UseProviderModelsSt
|
||||
const [loading, setLoading] = useState(false)
|
||||
const [error, setError] = useState<string | null>(null)
|
||||
const prevProviderKey = useRef<string>('')
|
||||
const requestIdRef = useRef(0)
|
||||
|
||||
const fetchModels = useCallback(async () => {
|
||||
if (!provider || !provider.base_url) {
|
||||
@ -44,11 +45,13 @@ export const useProviderModels = (provider?: ModelProvider): UseProviderModelsSt
|
||||
return
|
||||
}
|
||||
|
||||
const currentRequestId = ++requestIdRef.current
|
||||
setLoading(true)
|
||||
setError(null)
|
||||
|
||||
try {
|
||||
const fetchedModels = await fetchModelsFromProvider(provider)
|
||||
if (currentRequestId !== requestIdRef.current) return
|
||||
const sortedModels = fetchedModels.sort((a, b) => a.localeCompare(b))
|
||||
|
||||
setModels(sortedModels)
|
||||
@ -59,11 +62,12 @@ export const useProviderModels = (provider?: ModelProvider): UseProviderModelsSt
|
||||
timestamp: Date.now(),
|
||||
})
|
||||
} catch (err) {
|
||||
if (currentRequestId !== requestIdRef.current) return
|
||||
const errorMessage = err instanceof Error ? err.message : 'Failed to fetch models'
|
||||
setError(errorMessage)
|
||||
console.error(`Error fetching models from ${provider.provider}:`, err)
|
||||
} finally {
|
||||
setLoading(false)
|
||||
if (currentRequestId === requestIdRef.current) setLoading(false)
|
||||
}
|
||||
}, [provider])
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user