fix: prevent stale provider model requests from polluting UI state

This commit is contained in:
lugnicca 2025-09-02 18:19:12 +02:00
parent 70bf257e75
commit 3d0ce15fe8
2 changed files with 6 additions and 1 deletions

View File

@ -95,6 +95,7 @@ export const DialogAddModel = ({ provider, trigger }: DialogAddModelProps) => {
<span className="text-destructive">*</span> <span className="text-destructive">*</span>
</label> </label>
<ModelCombobox <ModelCombobox
key={`${provider.provider}-${provider.base_url || ''}`}
value={modelId} value={modelId}
onChange={setModelId} onChange={setModelId}
models={models} models={models}

View File

@ -16,6 +16,7 @@ export const useProviderModels = (provider?: ModelProvider): UseProviderModelsSt
const [loading, setLoading] = useState(false) const [loading, setLoading] = useState(false)
const [error, setError] = useState<string | null>(null) const [error, setError] = useState<string | null>(null)
const prevProviderKey = useRef<string>('') const prevProviderKey = useRef<string>('')
const requestIdRef = useRef(0)
const fetchModels = useCallback(async () => { const fetchModels = useCallback(async () => {
if (!provider || !provider.base_url) { if (!provider || !provider.base_url) {
@ -44,11 +45,13 @@ export const useProviderModels = (provider?: ModelProvider): UseProviderModelsSt
return return
} }
const currentRequestId = ++requestIdRef.current
setLoading(true) setLoading(true)
setError(null) setError(null)
try { try {
const fetchedModels = await fetchModelsFromProvider(provider) const fetchedModels = await fetchModelsFromProvider(provider)
if (currentRequestId !== requestIdRef.current) return
const sortedModels = fetchedModels.sort((a, b) => a.localeCompare(b)) const sortedModels = fetchedModels.sort((a, b) => a.localeCompare(b))
setModels(sortedModels) setModels(sortedModels)
@ -59,11 +62,12 @@ export const useProviderModels = (provider?: ModelProvider): UseProviderModelsSt
timestamp: Date.now(), timestamp: Date.now(),
}) })
} catch (err) { } catch (err) {
if (currentRequestId !== requestIdRef.current) return
const errorMessage = err instanceof Error ? err.message : 'Failed to fetch models' const errorMessage = err instanceof Error ? err.message : 'Failed to fetch models'
setError(errorMessage) setError(errorMessage)
console.error(`Error fetching models from ${provider.provider}:`, err) console.error(`Error fetching models from ${provider.provider}:`, err)
} finally { } finally {
setLoading(false) if (currentRequestId === requestIdRef.current) setLoading(false)
} }
}, [provider]) }, [provider])