From 45edb9cc51a1d24066f578e8050e809030d0ae3f Mon Sep 17 00:00:00 2001
From: Louis <louis@jan.ai>
Date: Sun, 9 Feb 2025 19:40:32 +0700
Subject: [PATCH] fix: error handling - pull remote models list raise an error
 on fail (#4615)

* chore: pull models list on /models update

* chore: correct engine extension name

* chore: fix undefined error

* chore: revert auto populating remote models on update
---
 .../engine-management-extension/src/index.ts  | 27 ++++++++++---------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/extensions/engine-management-extension/src/index.ts b/extensions/engine-management-extension/src/index.ts
index e4d7b57ac..5bf2ddade 100644
--- a/extensions/engine-management-extension/src/index.ts
+++ b/extensions/engine-management-extension/src/index.ts
@@ -25,10 +25,10 @@ interface ModelList {
   data: Model[]
 }
 /**
- * JSONEngineManagementExtension is a EngineManagementExtension implementation that provides
+ * JanEngineManagementExtension is a EngineManagementExtension implementation that provides
  * functionality for managing engines.
  */
-export default class JSONEngineManagementExtension extends EngineManagementExtension {
+export default class JanEngineManagementExtension extends EngineManagementExtension {
   queue = new PQueue({ concurrency: 1 })
 
   /**
@@ -356,17 +356,18 @@ export default class JSONEngineManagementExtension extends EngineManagementExten
   private populateRemoteModels = async (engineConfig: EngineConfig) => {
     return this.getRemoteModels(engineConfig.engine)
       .then((models: ModelList) => {
-        Promise.all(
-          models.data?.map((model) =>
-            this.addRemoteModel({
-              ...model,
-              engine: engineConfig.engine as InferenceEngine,
-              model: model.model ?? model.id,
-            }).catch(console.info)
-          )
-        ).then(() => {
-          events.emit(ModelEvent.OnModelsUpdate, { fetch: true })
-        })
+        if (models?.data)
+          Promise.all(
+            models.data.map((model) =>
+              this.addRemoteModel({
+                ...model,
+                engine: engineConfig.engine as InferenceEngine,
+                model: model.model ?? model.id,
+              }).catch(console.info)
+            )
+          ).then(() => {
+            events.emit(ModelEvent.OnModelsUpdate, { fetch: true })
+          })
       })
       .catch(console.info)
   }