Merge pull request #6020 from cmppoon/fix-mcp-servers-edit-json

fix connected servers status not in sync when edit mcp json

web-app/src/hooks/useMCPServers.ts

@@ -25,8 +25,8 @@ type MCPServerStoreState = {
   editServer: (key: string, config: MCPServerConfig) => void
   deleteServer: (key: string) => void
   setServers: (servers: MCPServers) => void
-  syncServers: () => void
-  syncServersAndRestart: () => void
+  syncServers: () => Promise<void>
+  syncServersAndRestart: () => Promise<void>
 }
 
 export const useMCPServers = create<MCPServerStoreState>()((set, get) => ({

web-app/src/routes/settings/mcp-servers.tsx

@@ -83,11 +83,7 @@ function MCPServers() {
   }
 
   const handleSaveServer = async (name: string, config: MCPServerConfig) => {
-    try {
-      await toggleServer(name, false)
-    } catch (error) {
-      console.error('Error deactivating server:', error)
-    }
+    toggleServer(name, false)
     if (editingKey) {
       // If server name changed, delete old one and add new one
       if (editingKey !== name) {
@@ -102,7 +98,7 @@ function MCPServers() {
     }
 
     syncServers()
-    await toggleServer(name, true)
+    toggleServer(name, true)
   }
 
   const handleEdit = (serverKey: string) => {
@@ -147,25 +143,26 @@ function MCPServers() {
   ) => {
     if (jsonServerName) {
       try {
-        await toggleServer(jsonServerName, false)
+        toggleServer(jsonServerName, false)
       } catch (error) {
         console.error('Error deactivating server:', error)
       }
       // Save single server
       editServer(jsonServerName, data as MCPServerConfig)
-      syncServers()
-      toggleServer(jsonServerName, true)
+      toggleServer(jsonServerName, (data as MCPServerConfig).active || false)
     } else {
       // Save all servers
       // Clear existing servers first
-      Object.keys(mcpServers).forEach((key) => {
-        deleteServer(key)
+      Object.keys(mcpServers).forEach((serverKey) => {
+        toggleServer(serverKey, false)
+        deleteServer(serverKey)
       })
 
       // Add all servers from the JSON
       Object.entries(data as Record<string, MCPServerConfig>).forEach(
         ([key, config]) => {
           addServer(key, config)
+          toggleServer(key, config.active || false)
         }
       )
     }