From 48f351aefd39bcc52933f602bacb1bc143010e25 Mon Sep 17 00:00:00 2001
From: Louis <louis@jan.ai>
Date: Wed, 24 Apr 2024 14:14:04 +0700
Subject: [PATCH] fix: new thread with overridden settings (#2798)

---
 web/containers/DropdownListSidebar/index.tsx | 9 +++++++++
 web/hooks/useCreateNewThread.ts              | 8 +++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/web/containers/DropdownListSidebar/index.tsx b/web/containers/DropdownListSidebar/index.tsx
index 5bb3d29cb..d8e878cca 100644
--- a/web/containers/DropdownListSidebar/index.tsx
+++ b/web/containers/DropdownListSidebar/index.tsx
@@ -134,10 +134,19 @@ const DropdownListSidebar = ({
       }
 
       if (activeThread) {
+        // Default setting ctx_len for the model for a better onboarding experience
+        // TODO: When Cortex support hardware instructions, we should remove this
+        const overriddenSettings =
+          model?.settings.ctx_len && model.settings.ctx_len > 2048
+            ? { ctx_len: 2048 }
+            : {}
+
         const modelParams = {
           ...model?.parameters,
           ...model?.settings,
+          ...overriddenSettings,
         }
+
         // Update model parameter to the thread state
         setThreadModelParams(activeThread.id, modelParams)
 
diff --git a/web/hooks/useCreateNewThread.ts b/web/hooks/useCreateNewThread.ts
index ef57bc982..e42bc1d4c 100644
--- a/web/hooks/useCreateNewThread.ts
+++ b/web/hooks/useCreateNewThread.ts
@@ -94,6 +94,11 @@ export const useCreateNewThread = () => {
       settings: assistant.tools && assistant.tools[0].settings,
     }
 
+    const overriddenSettings =
+      defaultModel?.settings.ctx_len && defaultModel.settings.ctx_len > 2048
+        ? { ctx_len: 2048 }
+        : {}
+
     const createdAt = Date.now()
     const assistantInfo: ThreadAssistantInfo = {
       assistant_id: assistant.id,
@@ -101,7 +106,7 @@ export const useCreateNewThread = () => {
       tools: experimentalEnabled ? [assistantTools] : assistant.tools,
       model: {
         id: defaultModel?.id ?? '*',
-        settings: defaultModel?.settings ?? {},
+        settings: { ...defaultModel?.settings, ...overriddenSettings } ?? {},
         parameters: defaultModel?.parameters ?? {},
         engine: defaultModel?.engine,
       },
@@ -126,6 +131,7 @@ export const useCreateNewThread = () => {
     setThreadModelParams(thread.id, {
       ...defaultModel?.settings,
       ...defaultModel?.parameters,
+      ...overriddenSettings,
     })
 
     // Delete the file upload state