Nicholai/jan
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: new extension settings aren't populated properly (#6476)

Browse Source
This commit is contained in:
Louis 2025-09-16 18:10:00 +07:00 committed by GitHub
parent 93807745cd
commit 5fa0826ee8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/browser/extension.ts
View File

@ -125,16 +125,17 @@ export abstract class BaseExtension implements ExtensionType {
settings.forEach((setting) => { settings.forEach((setting) => {
// Keep setting value // Keep setting value
if (setting.controllerProps && Array.isArray(oldSettings)) if (setting.controllerProps && Array.isArray(oldSettings))
setting.controllerProps.value = oldSettings.find( setting.controllerProps.value =
(e: any) => e.key === setting.key oldSettings.find((e: any) => e.key === setting.key)?.controllerProps?.value ??
)?.controllerProps?.value setting.controllerProps.value
if ('options' in setting.controllerProps) if ('options' in setting.controllerProps)
setting.controllerProps.options = setting.controllerProps.options?.length setting.controllerProps.options = setting.controllerProps.options?.length
? setting.controllerProps.options ? setting.controllerProps.options
: oldSettings.find((e: any) => e.key === setting.key)?.controllerProps?.options : oldSettings.find((e: any) => e.key === setting.key)?.controllerProps?.options
if ('recommended' in setting.controllerProps) { if ('recommended' in setting.controllerProps) {
const oldRecommended = oldSettings.find((e: any) => e.key === setting.key)?.controllerProps?.recommended const oldRecommended = oldSettings.find((e: any) => e.key === setting.key)
if (oldRecommended !== undefined && oldRecommended !== "") { ?.controllerProps?.recommended
if (oldRecommended !== undefined && oldRecommended !== '') {
setting.controllerProps.recommended = oldRecommended setting.controllerProps.recommended = oldRecommended
} }
} }