Nicholai/jan
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

enhancement: create new thread with last chosen model (#4524)

Browse Source 
* enhancement: create new thread with last chosen model

* chore: resolve setting undefined
This commit is contained in:
Faisal Amir 2025-01-27 20:22:39 +07:00 committed by GitHub
parent 7f6c8aa205
commit 628838442d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
web/hooks/useCreateNewThread.ts
View File

@ -51,11 +51,13 @@ export const useCreateNewThread = () => {
const { recommendedModel } = useRecommendedModel() const { recommendedModel } = useRecommendedModel()
const selectedModel = useAtomValue(selectedModelAtom)
const requestCreateNewThread = async ( const requestCreateNewThread = async (
assistant: (ThreadAssistantInfo & { id: string; name: string }) | Assistant, assistant: (ThreadAssistantInfo & { id: string; name: string }) | Assistant,
model?: Model | undefined model?: Model | undefined
) => { ) => {
const defaultModel = model || recommendedModel const defaultModel = model || selectedModel || recommendedModel
if (!model) { if (!model) {
// if we have model, which means user wants to create new thread from Model hub. Allow them. // if we have model, which means user wants to create new thread from Model hub. Allow them.
@ -82,12 +84,12 @@ export const useCreateNewThread = () => {
// Default context length is 8192 // Default context length is 8192
const defaultContextLength = Math.min( const defaultContextLength = Math.min(
8192, 8192,
defaultModel?.settings.ctx_len ?? 8192 defaultModel?.settings?.ctx_len ?? 8192
) )
const overriddenSettings = { const overriddenSettings = {
ctx_len: defaultModel?.settings.ctx_len ctx_len: defaultModel?.settings?.ctx_len
? Math.min(8192, defaultModel.settings.ctx_len) ? Math.min(8192, defaultModel?.settings?.ctx_len)
: undefined, : undefined,
} }
@ -95,10 +97,10 @@ export const useCreateNewThread = () => {
const overriddenParameters = { const overriddenParameters = {
max_tokens: defaultContextLength max_tokens: defaultContextLength
? Math.min( ? Math.min(
defaultModel?.parameters.max_tokens ?? 8192, defaultModel?.parameters?.max_tokens ?? 8192,
defaultContextLength defaultContextLength
) )
: defaultModel?.parameters.max_tokens, : defaultModel?.parameters?.max_tokens,
} }
const createdAt = Date.now() const createdAt = Date.now()