From 66cd1817f9341e594feacc6f27b6f8c374cb4c7f Mon Sep 17 00:00:00 2001 From: hiento09 <136591877+hiento09@users.noreply.github.com> Date: Fri, 15 Dec 2023 10:52:59 +0700 Subject: [PATCH] fix bug #1013, enable posthog for release app version only (#1019) Co-authored-by: Hien To --- .github/workflows/jan-electron-build.yml | 7 +++++++ web/next.config.js | 6 ++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/jan-electron-build.yml b/.github/workflows/jan-electron-build.yml index cf6489136..303970dc8 100644 --- a/.github/workflows/jan-electron-build.yml +++ b/.github/workflows/jan-electron-build.yml @@ -87,6 +87,8 @@ jobs: APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }} APP_PATH: "." DEVELOPER_ID: ${{ secrets.DEVELOPER_ID }} + ANALYTICS_ID: ${{ secrets.POSTHOG_PROJECT_API_KEY }} + ANALYTICS_HOST: ${{ secrets.POSTHOG_APP_URL }} build-windows-x64: runs-on: windows-latest @@ -125,6 +127,9 @@ jobs: shell: cmd run: | make build + env: + ANALYTICS_ID: ${{ secrets.POSTHOG_PROJECT_API_KEY }} + ANALYTICS_HOST: ${{ secrets.POSTHOG_APP_URL }} - name: Windows Code Sign with AzureSignTool run: | @@ -202,6 +207,8 @@ jobs: make build-and-publish env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + ANALYTICS_ID: ${{ secrets.POSTHOG_PROJECT_API_KEY }} + ANALYTICS_HOST: ${{ secrets.POSTHOG_APP_URL }} update_release_draft: needs: [build-macos, build-windows-x64, build-linux-x64, create-draft-release] diff --git a/web/next.config.js b/web/next.config.js index 936bd76ce..3d34cbdd7 100644 --- a/web/next.config.js +++ b/web/next.config.js @@ -29,11 +29,9 @@ const nextConfig = { ), VERSION: JSON.stringify(packageJson.version), ANALYTICS_ID: - process.env.ANALYTICS_ID ?? - JSON.stringify('phc_cJ95zWbMwdef6nVasPCoSNOvV8lUcL5IykIYOoyGXVm'), + JSON.stringify(process.env.ANALYTICS_ID) ?? JSON.stringify('xxx'), ANALYTICS_HOST: - process.env.ANALYTICS_HOST ?? - JSON.stringify('https://app.posthog.com'), + JSON.stringify(process.env.ANALYTICS_HOST) ?? JSON.stringify('xxx'), }), ] return config