From 81e8889568095a735acf3b93b72e88c4de91b1aa Mon Sep 17 00:00:00 2001 From: Andreas Deininger Date: Mon, 15 Apr 2024 08:27:28 +0200 Subject: [PATCH] Fix typos (#2714) --- charts/server/values.yaml | 4 ++-- core/src/browser/core.ts | 2 +- core/src/node/helper/resource.ts | 2 +- electron/utils/selectedText.ts | 2 +- electron/utils/setup.ts | 2 +- extensions/inference-nitro-extension/src/index.ts | 12 ++++++------ extensions/monitoring-extension/src/node/index.ts | 2 +- extensions/monitoring-extension/src/node/logger.ts | 2 +- server/helpers/setup.ts | 2 +- specs/adrs/adr-001-jan-deployable-cloud-native.md | 2 +- specs/adrs/adr-003-jan-plugins.md | 4 ++-- specs/adrs/adr-008-Extensible-Jan-with-Docker.md | 2 +- web/app/error.tsx | 2 +- web/constants/tagType.ts | 6 +++--- web/containers/DropdownListSidebar/index.tsx | 2 +- web/hooks/useGetSystemResources.ts | 2 +- .../HuggingFaceConvertingErrorModal/index.tsx | 2 +- .../ExploreModels/HuggingFaceSearchModal/index.tsx | 2 +- 18 files changed, 27 insertions(+), 27 deletions(-) diff --git a/charts/server/values.yaml b/charts/server/values.yaml index 73d4e8916..b31f47656 100644 --- a/charts/server/values.yaml +++ b/charts/server/values.yaml @@ -79,7 +79,7 @@ common: securityContext: {} service: - extenalLabel: {} + externalLabel: {} type: ClusterIP port: 1337 targetPort: 1337 @@ -193,7 +193,7 @@ common: securityContext: {} service: - extenalLabel: {} + externalLabel: {} type: ClusterIP port: 3000 targetPort: 3000 diff --git a/core/src/browser/core.ts b/core/src/browser/core.ts index 6bbae7c85..088c32e4e 100644 --- a/core/src/browser/core.ts +++ b/core/src/browser/core.ts @@ -60,7 +60,7 @@ const joinPath: (paths: string[]) => Promise = (paths) => globalThis.core.api?.joinPath(paths) /** - * Retrive the basename from an url. + * Retrieve the basename from an url. * @param path - The path to retrieve. * @returns {Promise} A promise that resolves with the basename. */ diff --git a/core/src/node/helper/resource.ts b/core/src/node/helper/resource.ts index 27e86c650..6c4a71478 100644 --- a/core/src/node/helper/resource.ts +++ b/core/src/node/helper/resource.ts @@ -4,7 +4,7 @@ import { log } from './logger' export const getSystemResourceInfo = async (): Promise => { const cpu = await physicalCpuCount() - log(`[NITRO]::CPU informations - ${cpu}`) + log(`[NITRO]::CPU information - ${cpu}`) return { numCpuPhysicalCore: cpu, diff --git a/electron/utils/selectedText.ts b/electron/utils/selectedText.ts index a39e331a9..25d31fab5 100644 --- a/electron/utils/selectedText.ts +++ b/electron/utils/selectedText.ts @@ -22,7 +22,7 @@ export const getSelectedText = async () => { /** * Registers a global shortcut of `accelerator`. The `callback` is called - * with the selected text when the registered shorcut is pressed by the user + * with the selected text when the registered shortcut is pressed by the user * * Returns `true` if the shortcut was registered successfully */ diff --git a/electron/utils/setup.ts b/electron/utils/setup.ts index 01b0b31da..d60ab47bb 100644 --- a/electron/utils/setup.ts +++ b/electron/utils/setup.ts @@ -3,7 +3,7 @@ import { app } from 'electron' export const setupCore = async () => { // Setup core api for main process global.core = { - // Define appPath function for app to retrieve app path globaly + // Define appPath function for app to retrieve app path globally appPath: () => app.getPath('userData'), } } diff --git a/extensions/inference-nitro-extension/src/index.ts b/extensions/inference-nitro-extension/src/index.ts index 119d7762f..9b1c79b04 100644 --- a/extensions/inference-nitro-extension/src/index.ts +++ b/extensions/inference-nitro-extension/src/index.ts @@ -42,7 +42,7 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine { /** * The interval id for the health check. Used to stop the health check. */ - private getNitroProcesHealthIntervalId: NodeJS.Timeout | undefined = undefined + private getNitroProcessHealthIntervalId: NodeJS.Timeout | undefined = undefined /** * Tracking the current state of nitro process. @@ -65,7 +65,7 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine { this.inferenceUrl = `${window.core?.api?.baseApiUrl}/v1/chat/completions` } - this.getNitroProcesHealthIntervalId = setInterval( + this.getNitroProcessHealthIntervalId = setInterval( () => this.periodicallyGetNitroHealth(), JanInferenceNitroExtension._intervalHealthCheck ) @@ -95,7 +95,7 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine { override loadModel(model: Model): Promise { if (model.engine !== this.provider) return Promise.resolve() - this.getNitroProcesHealthIntervalId = setInterval( + this.getNitroProcessHealthIntervalId = setInterval( () => this.periodicallyGetNitroHealth(), JanInferenceNitroExtension._intervalHealthCheck ) @@ -106,9 +106,9 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine { if (model?.engine && model.engine !== this.provider) return // stop the periocally health check - if (this.getNitroProcesHealthIntervalId) { - clearInterval(this.getNitroProcesHealthIntervalId) - this.getNitroProcesHealthIntervalId = undefined + if (this.getNitroProcessHealthIntervalId) { + clearInterval(this.getNitroProcessHealthIntervalId) + this.getNitroProcessHealthIntervalId = undefined } return super.unloadModel(model) } diff --git a/extensions/monitoring-extension/src/node/index.ts b/extensions/monitoring-extension/src/node/index.ts index bb0c4ac18..bb820c598 100644 --- a/extensions/monitoring-extension/src/node/index.ts +++ b/extensions/monitoring-extension/src/node/index.ts @@ -136,7 +136,7 @@ export const getCurrentLoad = () => }) /** - * This will retrive GPU informations and persist settings.json + * This will retrieve GPU information and persist settings.json * Will be called when the extension is loaded to turn on GPU acceleration if supported */ export const updateNvidiaInfo = async () => { diff --git a/extensions/monitoring-extension/src/node/logger.ts b/extensions/monitoring-extension/src/node/logger.ts index 3d53e5ed9..9bafa7451 100644 --- a/extensions/monitoring-extension/src/node/logger.ts +++ b/extensions/monitoring-extension/src/node/logger.ts @@ -53,7 +53,7 @@ export class FileLogger extends Logger { daysToKeep?: number | undefined ): void { // clear existing timeout - // incase we rerun it with different values + // in case we rerun it with different values if (this.timeout) clearTimeout(this.timeout) this.timeout = undefined diff --git a/server/helpers/setup.ts b/server/helpers/setup.ts index 7d8f8914a..41595d70c 100644 --- a/server/helpers/setup.ts +++ b/server/helpers/setup.ts @@ -12,7 +12,7 @@ export async function setup() { if (!existsSync(appDir)) mkdirSync(appDir) //@ts-ignore global.core = { - // Define appPath function for app to retrieve app path globaly + // Define appPath function for app to retrieve app path globally appPath: () => appDir, } init({ diff --git a/specs/adrs/adr-001-jan-deployable-cloud-native.md b/specs/adrs/adr-001-jan-deployable-cloud-native.md index acc34d7fc..d07bd26ff 100644 --- a/specs/adrs/adr-001-jan-deployable-cloud-native.md +++ b/specs/adrs/adr-001-jan-deployable-cloud-native.md @@ -22,7 +22,7 @@ * This ADR aims to outline design decisions for deploying Jan in cloud native environments such as: Runpod, AWS, Azure, GCP in a fast and simple way. * The current code-base should not change too much. -* The current plugins must be reusable across enviroments (Desktop, Cloud-native). +* The current plugins must be reusable across environments (Desktop, Cloud-native). ### Key Design Decisions diff --git a/specs/adrs/adr-003-jan-plugins.md b/specs/adrs/adr-003-jan-plugins.md index 827682975..8dd5b282a 100644 --- a/specs/adrs/adr-003-jan-plugins.md +++ b/specs/adrs/adr-003-jan-plugins.md @@ -14,8 +14,8 @@ Modular Architecture w/ Plugins: - Jan will have an architecture similar to VSCode or k8Lens - "Desktop Application" whose functionality can be extended thru plugins -- Jan's architecture will need to accomodate plugins for (a) Persistence(b) IAM(c) Teams and RBAC(d) Policy engines(e) "Apps" (i.e. higher-order business logic)(f) Themes (UI) -- Nitro's architecture will need to accomodate plugins for different "model backends"(a) llama.cpp(b) rkwk (and others)(c) 3rd-party AIs +- Jan's architecture will need to accommodate plugins for (a) Persistence(b) IAM(c) Teams and RBAC(d) Policy engines(e) "Apps" (i.e. higher-order business logic)(f) Themes (UI) +- Nitro's architecture will need to accommodate plugins for different "model backends"(a) llama.cpp(b) rkwk (and others)(c) 3rd-party AIs ## Decision diff --git a/specs/adrs/adr-008-Extensible-Jan-with-Docker.md b/specs/adrs/adr-008-Extensible-Jan-with-Docker.md index 7b13864a2..05e72956a 100644 --- a/specs/adrs/adr-008-Extensible-Jan-with-Docker.md +++ b/specs/adrs/adr-008-Extensible-Jan-with-Docker.md @@ -14,7 +14,7 @@ Proposed ## Context What is the issue that we're seeing that is motivating this decision or change? -- The A.I world is moving fast with multiple runtime/ prebaked environment. We or the builder cannot cover just everything but rather we should adopt it and facillitate it as much as possible within Jan. +- The A.I world is moving fast with multiple runtime/ prebaked environment. We or the builder cannot cover just everything but rather we should adopt it and facilitate it as much as possible within Jan. - For `Run your own A.I`: Builder can build app on Jan (NodeJS env) and connect to external endpoint which serves the real A.I - e.g 1: Nitro acting as proxy to `triton-inference-server` running within a Docker container controlled by Jan app - e.g 2: Original models can be in many formats (pytorch, paddlepaddle). In order to run it with the most optimized version locally, there must be a step to transpile the model ([Ollama import model](https://github.com/jmorganca/ollama/blob/main/docs/import.md), Tensorrt). Btw Jan can prebuilt it and let user pull but later diff --git a/web/app/error.tsx b/web/app/error.tsx index 25b24b9ef..ccf752620 100644 --- a/web/app/error.tsx +++ b/web/app/error.tsx @@ -62,7 +62,7 @@ export default function Error({ > contact us {' '} - if the problem presists. + if the problem persists.

{

- An error occured while {conversionStatus} model {repoData.id}. + An error occurred while {conversionStatus} model {repoData.id}.

Please close this modal and try again.

diff --git a/web/screens/ExploreModels/HuggingFaceSearchModal/index.tsx b/web/screens/ExploreModels/HuggingFaceSearchModal/index.tsx index a81df29fa..3add92ed1 100644 --- a/web/screens/ExploreModels/HuggingFaceSearchModal/index.tsx +++ b/web/screens/ExploreModels/HuggingFaceSearchModal/index.tsx @@ -21,7 +21,7 @@ export const HuggingFaceSearchModal = () => { return ( <>
-

Hugging Face Convertor

+

Hugging Face Converter

Type the repository id below