From 9effb6a3a6b9e63f68ac877748855b343a31b983 Mon Sep 17 00:00:00 2001 From: Faisal Amir Date: Mon, 6 May 2024 16:48:53 +0700 Subject: [PATCH] fix: validate context length (#2871) * fix: adjust context_length min and conditional for remote model * fix: remove console --- web/screens/Chat/ModelSetting/SettingComponent.tsx | 5 ++++- web/screens/Chat/ModelSetting/predefinedComponent.ts | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/web/screens/Chat/ModelSetting/SettingComponent.tsx b/web/screens/Chat/ModelSetting/SettingComponent.tsx index 2fde17276..396043f77 100644 --- a/web/screens/Chat/ModelSetting/SettingComponent.tsx +++ b/web/screens/Chat/ModelSetting/SettingComponent.tsx @@ -3,6 +3,7 @@ import { InputComponentProps, CheckboxComponentProps, SliderComponentProps, + InferenceEngine, } from '@janhq/core' import { useAtomValue } from 'jotai/react' @@ -37,7 +38,9 @@ const SettingComponent: React.FC = ({ description={data.description} min={min} max={ - data.key === 'max_tokens' + data.key === 'max_tokens' && + activeThread && + activeThread.assistants[0].model.engine === InferenceEngine.nitro ? Number( activeThread && activeThread.assistants[0].model.settings.ctx_len diff --git a/web/screens/Chat/ModelSetting/predefinedComponent.ts b/web/screens/Chat/ModelSetting/predefinedComponent.ts index 652389d4a..91c3f71e1 100644 --- a/web/screens/Chat/ModelSetting/predefinedComponent.ts +++ b/web/screens/Chat/ModelSetting/predefinedComponent.ts @@ -33,7 +33,7 @@ export const presetConfiguration: Record = { 'The context length for model operations varies; the maximum depends on the specific model used.', controllerType: 'slider', controllerProps: { - min: 0, + min: 128, max: 4096, step: 128, value: 2048,