Nicholai/jan
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4119 from janhq/fix/invalid-request-should-not-show-invalid-api-key

Browse Source 
fix: 3986 - invalid request should show clear error message
This commit is contained in:
Louis 2024-11-26 19:54:11 +07:00 committed by GitHub
commit b046ee3e22
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
electron/tests/e2e/thread.e2e.spec.ts
View File

@ -25,7 +25,7 @@ test('Select GPT model from Hub and Chat with Invalid API Key', async ({
{ timeout: TIMEOUT } { timeout: TIMEOUT }
) )
const APIKeyError = page.getByTestId('invalid-API-key-error') const APIKeyError = page.getByTestId('passthrough-error-message')
await expect(APIKeyError).toBeVisible({ await expect(APIKeyError).toBeVisible({
timeout: TIMEOUT, timeout: TIMEOUT,
}) })

3
web/containers/ErrorMessage/index.tsx
View File

@ -29,7 +29,6 @@ const ErrorMessage = ({ message }: { message: ThreadMessage }) => {
switch (message.error_code) { switch (message.error_code) {
case ErrorCode.InvalidApiKey: case ErrorCode.InvalidApiKey:
case ErrorCode.AuthenticationError: case ErrorCode.AuthenticationError:
case ErrorCode.InvalidRequestError:
return ( return (
<span data-testid="invalid-API-key-error"> <span data-testid="invalid-API-key-error">
Invalid API key. Please check your API key from{' '} Invalid API key. Please check your API key from{' '}
@ -53,7 +52,7 @@ const ErrorMessage = ({ message }: { message: ThreadMessage }) => {
) )
default: default:
return ( return (
<p> <p data-testid="passthrough-error-message">
{message.content[0]?.text?.value && ( {message.content[0]?.text?.value && (
<AutoLink text={message.content[0].text.value} /> <AutoLink text={message.content[0].text.value} />
)} )}