Nicholai/jan
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: separate kill subprocess and dispose functions

Browse Source
This commit is contained in:
Louis 2023-10-03 16:11:13 +07:00 committed by Louis
parent fd512f2cee
commit d0e484a663
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
electron/core/plugins/inference-plugin/index.js
View File

@ -13,7 +13,7 @@ const dispose = async () =>
new Promise(async (resolve) => { new Promise(async (resolve) => {
if (window.electronAPI) { if (window.electronAPI) {
window.electronAPI window.electronAPI
.invokePluginFunc(MODULE_PATH, "killSubprocess") .invokePluginFunc(MODULE_PATH, "dispose")
.then((res) => resolve(res)); .then((res) => resolve(res));
} }
}); });

6
electron/core/plugins/inference-plugin/module.js
View File

@ -72,6 +72,11 @@ async function initModel(product) {
} }
function dispose() { function dispose() {
killSubprocess();
// clean other registered resources here
}
function killSubprocess() {
if (subprocess) { if (subprocess) {
subprocess.kill(); subprocess.kill();
subprocess = null; subprocess = null;
@ -83,5 +88,6 @@ function dispose() {
module.exports = { module.exports = {
initModel, initModel,
killSubprocess,
dispose, dispose,
}; };