fix: override cpu_threads setting from model.json (#2789)

core/src/node/api/restful/helper/startStopModel.ts

@@ -63,11 +63,11 @@ const runModel = async (modelId: string, settingParams?: ModelSettingParams): Pr
 
   const nitroResourceProbe = await getSystemResourceInfo()
   const nitroModelSettings: NitroModelSettings = {
+    // This is critical and requires real CPU physical core count (or performance core)
+    cpu_threads: Math.max(1, nitroResourceProbe.numCpuPhysicalCore),
     ...modelMetadata.settings,
     ...settingParams,
     llama_model_path: modelBinaryPath,
-    // This is critical and requires real CPU physical core count (or performance core)
-    cpu_threads: Math.max(1, nitroResourceProbe.numCpuPhysicalCore),
     ...(modelMetadata.settings.mmproj && {
       mmproj: join(modelFolderFullPath, modelMetadata.settings.mmproj),
     }),

extensions/assistant-extension/src/node/engine.ts

@@ -15,6 +15,8 @@ export const readEmbeddingEngine = (engineName: string) => {
     const settingDirectoryPath = path.join(
       getJanDataFolderPath(),
       'settings',
+      '@janhq',
+      // TODO: James - To be removed
       engineName === 'openai'
         ? 'inference-openai-extension'
         : 'inference-groq-extension',

extensions/inference-nitro-extension/src/node/index.ts

@@ -131,10 +131,11 @@ async function loadModel(
     if (!llama_model_path) return Promise.reject('No GGUF model file found')
 
     currentSettings = {
+      cpu_threads: Math.max(1, nitroResourceProbe.numCpuPhysicalCore),
+      // model.settings can override the default settings
       ...params.model.settings,
       llama_model_path,
       // This is critical and requires real CPU physical core count (or performance core)
-      cpu_threads: Math.max(1, nitroResourceProbe.numCpuPhysicalCore),
       ...(params.model.settings.mmproj && {
         mmproj: path.isAbsolute(params.model.settings.mmproj)
           ? params.model.settings.mmproj

extensions/monitoring-extension/src/node/logger.ts

@@ -67,9 +67,9 @@ export class FileLogger extends Logger {
     const size = maxFileSizeBytes ?? 1 * 1024 * 1024 // 1 MB
     const days = daysToKeep ?? 7 // 7 days
     const logDirectory = path.join(getJanDataFolderPath(), 'logs')
-
     // Perform log cleaning
     const currentDate = new Date()
+    if (fs.existsSync(logDirectory))
       fs.readdir(logDirectory, (err, files) => {
         if (err) {
           console.error('Error reading log directory:', err)

web/containers/ServerLogs/index.tsx

@@ -97,7 +97,7 @@ const ServerLogs = (props: ServerLogsProps) => {
         </div>
       </div>
       <div className="overflow-hidden">
-        {logs.length > 1 ? (
+        {logs.length > 0 ? (
           <div className="h-full overflow-auto">
             <code className="inline-block whitespace-pre-line text-xs">
               {logs.slice(-limit).map((log, i) => {

web/screens/Chat/ModelSetting/predefinedComponent.ts

@@ -165,6 +165,21 @@ export const presetConfiguration: Record<string, SettingComponentProps> = {
     requireModelReload: true,
     configType: 'setting',
   },
+  cpu_threads: {
+    key: 'cpu_threads',
+    title: 'CPU Threads',
+    description:
+      'Determines CPU inference threads, limited by hardware and OS. (Maximum determined by system)',
+    controllerType: 'slider',
+    controllerProps: {
+      min: 0,
+      max: 128,
+      step: 1,
+      value: 1,
+    },
+    requireModelReload: true,
+    configType: 'setting',
+  },
   // assistant
   chunk_size: {
     key: 'chunk_size',