Nicholai/jan
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Fix tests on useChat

Browse Source
This commit is contained in:
Vanalite 2025-10-03 10:17:27 +07:00
parent 4ac45aba23
commit e7c9275488
1 changed files with 49 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
web-app/src/hooks/__tests__/useChat.test.ts
View File

@ -333,7 +333,7 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('Hello world', true, undefined, undefined)
await result.current('Hello world', true, undefined, undefined, undefined)
})
expect(completionLib.newUserThreadContent).toHaveBeenCalledWith(
@ -367,7 +367,7 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('Continue', true, undefined, 'msg-123')
await result.current('', true, undefined, undefined, 'msg-123')
})
expect(completionLib.newUserThreadContent).not.toHaveBeenCalled()
@ -392,14 +392,18 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('', true, undefined, 'msg-123')
await result.current('', true, undefined, undefined, 'msg-123')
})
expect(mockCompletionMessagesBuilder.addAssistantMessage).toHaveBeenCalledWith(
// Should be called twice: once with partial message (line 517-521), once after completion (line 689)
const assistantCalls = mockCompletionMessagesBuilder.addAssistantMessage.mock.calls
expect(assistantCalls.length).toBeGreaterThanOrEqual(1)
// First call should be with the partial response content
expect(assistantCalls[0]).toEqual([
'Partial response',
undefined,
[]
)
])
})
it('should filter out stopped message from context when continuing', async () => {
@ -421,15 +425,15 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('', true, undefined, 'msg-123')
await result.current('', true, undefined, undefined, 'msg-123')
})
await waitFor(() => {
expect(messagesLib.CompletionMessagesBuilder).toHaveBeenCalledWith(
[userMsg], // stopped message filtered out
'test instructions'
)
})
// The CompletionMessagesBuilder is called with filtered messages (line 507-512)
// The stopped message should be filtered out from the context
expect(messagesLib.CompletionMessagesBuilder).toHaveBeenCalled()
const builderCall = (messagesLib.CompletionMessagesBuilder as any).mock.calls[0]
expect(builderCall[0]).toEqual([userMsg]) // stopped message filtered out
expect(builderCall[1]).toEqual('test instructions')
})
it('should update existing message instead of adding new one when continuing', async () => {
@ -446,17 +450,16 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('', true, undefined, 'msg-123')
await result.current('', true, undefined, undefined, 'msg-123')
})
await waitFor(() => {
expect(mockUpdateMessage).toHaveBeenCalledWith(
expect.objectContaining({
id: 'msg-123',
status: MessageStatus.Ready,
})
)
})
// finalizeMessage is called at line 700-708, which should update the message
expect(mockUpdateMessage).toHaveBeenCalledWith(
expect.objectContaining({
id: 'msg-123',
status: MessageStatus.Ready,
})
)
})
it('should start with previous content when continuing', async () => {
@ -482,24 +485,24 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('', true, undefined, 'msg-123')
await result.current('', true, undefined, undefined, 'msg-123')
})
// The accumulated text should contain the previous content
await waitFor(() => {
expect(mockUpdateMessage).toHaveBeenCalledWith(
expect.objectContaining({
id: 'msg-123',
content: expect.arrayContaining([
expect.objectContaining({
text: expect.objectContaining({
value: expect.stringContaining('Partial response'),
})
// The accumulated text should contain the previous content plus new content
// accumulatedTextRef starts with 'Partial response' (line 490)
// Then gets ' continued' appended (line 585)
expect(mockUpdateMessage).toHaveBeenCalledWith(
expect.objectContaining({
id: 'msg-123',
content: expect.arrayContaining([
expect.objectContaining({
text: expect.objectContaining({
value: 'Partial response continued',
})
])
})
)
})
})
])
})
)
})
it('should handle attachments correctly when not continuing', async () => {
@ -515,7 +518,7 @@ describe('useChat', () => {
]
await act(async () => {
await result.current('Message with attachment', true, attachments, undefined)
await result.current('Message with attachment', true, attachments, undefined, undefined)
})
expect(completionLib.newUserThreadContent).toHaveBeenCalledWith(
@ -543,17 +546,16 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('', true, undefined, 'msg-123')
await result.current('', true, undefined, undefined, 'msg-123')
})
await waitFor(() => {
expect(mockUpdateMessage).toHaveBeenCalledWith(
expect.objectContaining({
id: 'msg-123',
status: MessageStatus.Ready,
})
)
})
// finalContent is created at line 678-683 with status Ready when continuing
expect(mockUpdateMessage).toHaveBeenCalledWith(
expect.objectContaining({
id: 'msg-123',
status: MessageStatus.Ready,
})
)
})
})
@ -586,7 +588,7 @@ describe('useChat', () => {
const { result } = renderHook(() => useChat())
await act(async () => {
await result.current('', true, undefined, 'msg-123')
await result.current('', true, undefined, undefined, 'msg-123')
})
expect(result.current).toBeDefined()