Nicholai/jan
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: jan beta logo displayed in jan release (#4828)

Browse Source
This commit is contained in:
Nguyen Ngoc Minh 2025-03-21 22:45:07 +07:00 committed by GitHub
parent 7e46295af1
commit ef172dc6c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
14 changed files with 53 additions and 88 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/jan-electron-build.yml vendored
View File

@ -40,6 +40,8 @@ jobs:
with: with:
ref: ${{ github.ref }} ref: ${{ github.ref }}
public_provider: github public_provider: github
beta: false
nightly: false
new_version: ${{ needs.get-update-version.outputs.new_version }} new_version: ${{ needs.get-update-version.outputs.new_version }}
build-windows-x64: build-windows-x64:
@ -49,6 +51,8 @@ jobs:
with: with:
ref: ${{ github.ref }} ref: ${{ github.ref }}
public_provider: github public_provider: github
beta: false
nightly: false
new_version: ${{ needs.get-update-version.outputs.new_version }} new_version: ${{ needs.get-update-version.outputs.new_version }}
build-linux-x64: build-linux-x64:
@ -58,6 +62,8 @@ jobs:
with: with:
ref: ${{ github.ref }} ref: ${{ github.ref }}
public_provider: github public_provider: github
beta: false
nightly: false
new_version: ${{ needs.get-update-version.outputs.new_version }} new_version: ${{ needs.get-update-version.outputs.new_version }}
update_release_draft: update_release_draft:

53
.github/workflows/template-build-linux-x64.yml vendored
View File

@ -55,55 +55,26 @@ jobs:
if: inputs.beta == true && inputs.nightly != true if: inputs.beta == true && inputs.nightly != true
shell: bash shell: bash
run: | run: |
echo "Icons before replacement:" rm -rf electron/icons/*
ls -la electron/icons/
echo "Setting up beta icons" cp electron/icons_dev/jan-beta-512x512.png electron/icons/512x512.png
cp electron/icons_dev/jan-beta.ico electron/icons/icon.ico
# Replace the key icon files with move operations (no need for rm first) cp electron/icons_dev/jan-beta.png electron/icons/icon.png
mv electron/icons/jan-beta-512x512.png electron/icons/512x512.png cp electron/icons_dev/jan-beta-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-beta.ico electron/icons/icon.ico cp electron/icons_dev/jan-beta-tray.png electron/icons/icon-tray.png
mv electron/icons/jan-beta.png electron/icons/icon.png
mv electron/icons/jan-beta-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-beta-tray.png electron/icons/icon-tray.png
# Remove any remaining nightly icon files
rm -f electron/icons/jan-nightly-512x512.png
rm -f electron/icons/jan-nightly.ico
rm -f electron/icons/jan-nightly.png
rm -f electron/icons/jan-nightly-tray@2x.png
rm -f electron/icons/jan-nightly-tray.png
# Verify the replacement
echo "Icons after replacement:"
ls -la electron/icons/
- name: Replace Icons for Nightly Build - name: Replace Icons for Nightly Build
if: inputs.nightly == true && inputs.beta != true if: inputs.nightly == true && inputs.beta != true
shell: bash shell: bash
run: | run: |
echo "Icons before replacement:" rm -rf electron/icons/*
ls -la electron/icons/
echo "Setting up nightly icons" cp electron/icons_dev/jan-nightly-512x512.png electron/icons/512x512.png
cp electron/icons_dev/jan-nightly.ico electron/icons/icon.ico
cp electron/icons_dev/jan-nightly.png electron/icons/icon.png
cp electron/icons_dev/jan-nightly-tray@2x.png electron/icons/icon-tray@2x.png
cp electron/icons_dev/jan-nightly-tray.png electron/icons/icon-tray.png
# Replace the key icon files with move operations (no need for rm first)
mv electron/icons/jan-nightly-512x512.png electron/icons/512x512.png
mv electron/icons/jan-nightly.ico electron/icons/icon.ico
mv electron/icons/jan-nightly.png electron/icons/icon.png
mv electron/icons/jan-nightly-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-nightly-tray.png electron/icons/icon-tray.png
# Remove any remaining beta icon files
rm -f electron/icons/jan-beta-512x512.png
rm -f electron/icons/jan-beta.ico
rm -f electron/icons/jan-beta.png
rm -f electron/icons/jan-beta-tray@2x.png
rm -f electron/icons/jan-beta-tray.png
# Verify the replacement
echo "Icons after replacement:"
ls -la electron/icons/
- name: Installing node - name: Installing node
uses: actions/setup-node@v1 uses: actions/setup-node@v1

34
.github/workflows/template-build-macos.yml vendored
View File

@ -65,31 +65,25 @@ jobs:
if: inputs.beta == true && inputs.nightly != true if: inputs.beta == true && inputs.nightly != true
shell: bash shell: bash
run: | run: |
rm -f electron/icons/512x512.png rm -rf electron/icons/*
rm -f electron/icons/icon.ico
rm -f electron/icons/icon.png cp electron/icons_dev/jan-beta-512x512.png electron/icons/512x512.png
rm -f electron/icons/icon-tray@2x.png cp electron/icons_dev/jan-beta.ico electron/icons/icon.ico
rm -f electron/icons/icon-tray.png cp electron/icons_dev/jan-beta.png electron/icons/icon.png
mv electron/icons/jan-beta-512x512.png electron/icons/512x512.png cp electron/icons_dev/jan-beta-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-beta.ico electron/icons/icon.ico cp electron/icons_dev/jan-beta-tray.png electron/icons/icon-tray.png
mv electron/icons/jan-beta.png electron/icons/icon.png
mv electron/icons/jan-beta-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-beta-tray.png electron/icons/icon-tray.png
- name: Replace Icons for Nightly Build - name: Replace Icons for Nightly Build
if: inputs.nightly == true && inputs.beta != true if: inputs.nightly == true && inputs.beta != true
shell: bash shell: bash
run: | run: |
rm -f electron/icons/512x512.png rm -rf electron/icons/*
rm -f electron/icons/icon.ico
rm -f electron/icons/icon.png cp electron/icons_dev/jan-nightly-512x512.png electron/icons/512x512.png
rm -f electron/icons/icon-tray@2x.png cp electron/icons_dev/jan-nightly.ico electron/icons/icon.ico
rm -f electron/icons/icon-tray.png cp electron/icons_dev/jan-nightly.png electron/icons/icon.png
mv electron/icons/jan-nightly-512x512.png electron/icons/512x512.png cp electron/icons_dev/jan-nightly-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-nightly.ico electron/icons/icon.ico cp electron/icons_dev/jan-nightly-tray.png electron/icons/icon-tray.png
mv electron/icons/jan-nightly.png electron/icons/icon.png
mv electron/icons/jan-nightly-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-nightly-tray.png electron/icons/icon-tray.png
- name: Installing node - name: Installing node
uses: actions/setup-node@v1 uses: actions/setup-node@v1

34
.github/workflows/template-build-windows-x64.yml vendored
View File

@ -64,31 +64,25 @@ jobs:
if: inputs.beta == true && inputs.nightly != true if: inputs.beta == true && inputs.nightly != true
shell: bash shell: bash
run: | run: |
rm -f electron/icons/512x512.png rm -rf electron/icons/*
rm -f electron/icons/icon.ico
rm -f electron/icons/icon.png cp electron/icons_dev/jan-beta-512x512.png electron/icons/512x512.png
rm -f electron/icons/icon-tray@2x.png cp electron/icons_dev/jan-beta.ico electron/icons/icon.ico
rm -f electron/icons/icon-tray.png cp electron/icons_dev/jan-beta.png electron/icons/icon.png
mv electron/icons/jan-beta-512x512.png electron/icons/512x512.png cp electron/icons_dev/jan-beta-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-beta.ico electron/icons/icon.ico cp electron/icons_dev/jan-beta-tray.png electron/icons/icon-tray.png
mv electron/icons/jan-beta.png electron/icons/icon.png
mv electron/icons/jan-beta-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-beta-tray.png electron/icons/icon-tray.png
- name: Replace Icons for Nightly Build - name: Replace Icons for Nightly Build
if: inputs.nightly == true && inputs.beta != true if: inputs.nightly == true && inputs.beta != true
shell: bash shell: bash
run: | run: |
rm -f electron/icons/512x512.png rm -rf electron/icons/*
rm -f electron/icons/icon.ico
rm -f electron/icons/icon.png cp electron/icons_dev/jan-nightly-512x512.png electron/icons/512x512.png
rm -f electron/icons/icon-tray@2x.png cp electron/icons_dev/jan-nightly.ico electron/icons/icon.ico
rm -f electron/icons/icon-tray.png cp electron/icons_dev/jan-nightly.png electron/icons/icon.png
mv electron/icons/jan-nightly-512x512.png electron/icons/512x512.png cp electron/icons_dev/jan-nightly-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-nightly.ico electron/icons/icon.ico cp electron/icons_dev/jan-nightly-tray.png electron/icons/icon-tray.png
mv electron/icons/jan-nightly.png electron/icons/icon.png
mv electron/icons/jan-nightly-tray@2x.png electron/icons/icon-tray@2x.png
mv electron/icons/jan-nightly-tray.png electron/icons/icon-tray.png
- name: Installing node - name: Installing node
uses: actions/setup-node@v1 uses: actions/setup-node@v1

0
electron/icons/jan-beta-512x512.png → electron/icons_dev/jan-beta-512x512.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 49 KiB

After

Width:  |  Height:  |  Size: 49 KiB

0
electron/icons/jan-beta-tray.png → electron/icons_dev/jan-beta-tray.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 806 B

After

Width:  |  Height:  |  Size: 806 B

0
electron/icons/jan-beta-tray@2x.png → electron/icons_dev/jan-beta-tray@2x.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 1.8 KiB

After

Width:  |  Height:  |  Size: 1.8 KiB

0
electron/icons/jan-beta.ico → electron/icons_dev/jan-beta.ico
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 26 KiB

After

Width:  |  Height:  |  Size: 26 KiB

0
electron/icons/jan-beta.png → electron/icons_dev/jan-beta.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 49 KiB

After

Width:  |  Height:  |  Size: 49 KiB

0
electron/icons/jan-nightly-512x512.png → electron/icons_dev/jan-nightly-512x512.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 49 KiB

After

Width:  |  Height:  |  Size: 49 KiB

0
electron/icons/jan-nightly-tray.png → electron/icons_dev/jan-nightly-tray.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 835 B

After

Width:  |  Height:  |  Size: 835 B

0
electron/icons/jan-nightly-tray@2x.png → electron/icons_dev/jan-nightly-tray@2x.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 1.9 KiB

After

Width:  |  Height:  |  Size: 1.9 KiB

0
electron/icons/jan-nightly.ico → electron/icons_dev/jan-nightly.ico
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 28 KiB

After

Width:  |  Height:  |  Size: 28 KiB

0
electron/icons/jan-nightly.png → electron/icons_dev/jan-nightly.png
View File

Side by Side Swipe Overlay

Before

Width:  |  Height:  |  Size: 49 KiB

After

Width:  |  Height:  |  Size: 49 KiB