Nicholai
b20db98051
Some checks failed
CI / build-and-test (pull_request) Failing after 1m19s
CI (.gitea/workflows/ci.yaml): lint → typecheck → vitest w/ coverage → OpenNext build → preview smoke → bundle-size budgets; Node 20; npm ci; artifacts; safe env; D1 dry-run scaffold. Budgets: add scripts/budgets.mjs; TOTAL_STATIC_MAX_BYTES and MAX_ASSET_BYTES thresholds; report top offenders; fail on breach; README CI section. Flags: add lib/flags.ts with typed booleans and safe defaults (ADMIN_ENABLED, ARTISTS_MODULE_ENABLED, UPLOADS_ADMIN_ENABLED, BOOKING_ENABLED, PUBLIC_APPOINTMENT_REQUESTS_ENABLED, REFERENCE_UPLOADS_PUBLIC_ENABLED, DEPOSITS_ENABLED, PUBLIC_DB_ARTISTS_ENABLED, ADVANCED_NAV_SCROLL_ANIMATIONS_ENABLED, STRICT_CI_GATES_ENABLED, ISR_CACHE_R2_ENABLED); robust parsing; client provider; unit tests. Wiring: gate Admin shell and admin write APIs (503 JSON on uploads and artists writes); disable booking submit and short-circuit booking mutations when off; render static Hero/Artists when advanced animations off; tests for UI and API guards. Ops: expand docs/prd/rollback-strategy.md with “Feature Flags Operations,” Cloudflare Dashboard and wrangler.toml steps, preview simulation, incident playbook, and post-toggle smoke checklist. Release: add docs/releases/2025-09-19-feature-flags-rollout.md with last-good commit, preview/production flag matrices, rollback notes, and smoke results; link from rollback doc. Chore: fix TS issues (gift-cards boolean handling, Lenis options, tailwind darkMode), remove next-on-pages peer conflict, update package.json scripts, configure Gitea act_runner label, open draft PR to trigger CI. Refs: CI-1, FF-1, FF-2, FF-3, OPS-1 Impact: defaults preserve current behavior; no runtime changes unless flags flipped
93 lines
2.5 KiB
TypeScript
93 lines
2.5 KiB
TypeScript
import { beforeEach, afterEach, describe, expect, it, vi } from "vitest"
|
|
|
|
import {
|
|
FLAG_DEFAULTS,
|
|
Flags,
|
|
getFlags,
|
|
registerRuntimeFlags,
|
|
resetFlagsCache,
|
|
parseBool,
|
|
} from "@/lib/flags"
|
|
|
|
type FlagName = keyof typeof FLAG_DEFAULTS
|
|
const flagKeys = Object.keys(FLAG_DEFAULTS) as FlagName[]
|
|
|
|
const originalEnv: Partial<Record<FlagName, string | undefined>> = {}
|
|
|
|
beforeEach(() => {
|
|
resetFlagsCache()
|
|
for (const key of flagKeys) {
|
|
if (!(key in originalEnv)) {
|
|
originalEnv[key] = process.env[key]
|
|
}
|
|
delete process.env[key]
|
|
}
|
|
delete (globalThis as Record<string, unknown>).__UNITED_TATTOO_RUNTIME_FLAGS__
|
|
})
|
|
|
|
afterEach(() => {
|
|
resetFlagsCache()
|
|
for (const key of flagKeys) {
|
|
const value = originalEnv[key]
|
|
if (value === undefined) {
|
|
delete process.env[key]
|
|
} else {
|
|
process.env[key] = value
|
|
}
|
|
}
|
|
delete (globalThis as Record<string, unknown>).__UNITED_TATTOO_RUNTIME_FLAGS__
|
|
})
|
|
|
|
describe("parseBool", () => {
|
|
it("handles string coercion and defaults", () => {
|
|
expect(parseBool("true", false)).toBe(true)
|
|
expect(parseBool(" FALSE ", true)).toBe(false)
|
|
expect(parseBool("1", false)).toBe(true)
|
|
expect(parseBool(undefined, true)).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe("getFlags", () => {
|
|
it("falls back to defaults and logs missing keys", () => {
|
|
const warnSpy = vi.spyOn(console, "warn").mockImplementation(() => {})
|
|
|
|
const snapshot = getFlags({ refresh: true })
|
|
|
|
expect(snapshot).toMatchObject(FLAG_DEFAULTS)
|
|
expect(warnSpy).toHaveBeenCalled()
|
|
|
|
warnSpy.mockRestore()
|
|
})
|
|
|
|
it("honours environment overrides", () => {
|
|
process.env.BOOKING_ENABLED = "false"
|
|
process.env.PUBLIC_APPOINTMENT_REQUESTS_ENABLED = "true"
|
|
|
|
const snapshot = getFlags({ refresh: true })
|
|
|
|
expect(snapshot.BOOKING_ENABLED).toBe(false)
|
|
expect(snapshot.PUBLIC_APPOINTMENT_REQUESTS_ENABLED).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe("registerRuntimeFlags", () => {
|
|
it("allows runtime overrides to take precedence", () => {
|
|
process.env.BOOKING_ENABLED = "true"
|
|
const override = { ...FLAG_DEFAULTS, BOOKING_ENABLED: false } as typeof FLAG_DEFAULTS
|
|
|
|
registerRuntimeFlags(override)
|
|
const snapshot = getFlags()
|
|
|
|
expect(snapshot.BOOKING_ENABLED).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe("Flags proxy", () => {
|
|
it("reflects current snapshot values", () => {
|
|
process.env.ADMIN_ENABLED = "false"
|
|
const snapshot = getFlags({ refresh: true })
|
|
expect(snapshot.ADMIN_ENABLED).toBe(false)
|
|
expect(Flags.ADMIN_ENABLED).toBe(false)
|
|
})
|
|
})
|