Nicholai
b20db98051
Some checks failed
CI / build-and-test (pull_request) Failing after 1m19s
CI (.gitea/workflows/ci.yaml): lint → typecheck → vitest w/ coverage → OpenNext build → preview smoke → bundle-size budgets; Node 20; npm ci; artifacts; safe env; D1 dry-run scaffold. Budgets: add scripts/budgets.mjs; TOTAL_STATIC_MAX_BYTES and MAX_ASSET_BYTES thresholds; report top offenders; fail on breach; README CI section. Flags: add lib/flags.ts with typed booleans and safe defaults (ADMIN_ENABLED, ARTISTS_MODULE_ENABLED, UPLOADS_ADMIN_ENABLED, BOOKING_ENABLED, PUBLIC_APPOINTMENT_REQUESTS_ENABLED, REFERENCE_UPLOADS_PUBLIC_ENABLED, DEPOSITS_ENABLED, PUBLIC_DB_ARTISTS_ENABLED, ADVANCED_NAV_SCROLL_ANIMATIONS_ENABLED, STRICT_CI_GATES_ENABLED, ISR_CACHE_R2_ENABLED); robust parsing; client provider; unit tests. Wiring: gate Admin shell and admin write APIs (503 JSON on uploads and artists writes); disable booking submit and short-circuit booking mutations when off; render static Hero/Artists when advanced animations off; tests for UI and API guards. Ops: expand docs/prd/rollback-strategy.md with “Feature Flags Operations,” Cloudflare Dashboard and wrangler.toml steps, preview simulation, incident playbook, and post-toggle smoke checklist. Release: add docs/releases/2025-09-19-feature-flags-rollout.md with last-good commit, preview/production flag matrices, rollback notes, and smoke results; link from rollback doc. Chore: fix TS issues (gift-cards boolean handling, Lenis options, tailwind darkMode), remove next-on-pages peer conflict, update package.json scripts, configure Gitea act_runner label, open draft PR to trigger CI. Refs: CI-1, FF-1, FF-2, FF-3, OPS-1 Impact: defaults preserve current behavior; no runtime changes unless flags flipped
49 lines
1.3 KiB
YAML
49 lines
1.3 KiB
YAML
schema: 1
|
|
story: 'FF-2'
|
|
story_title: 'Wire Flags to Critical Surfaces — Admin/Booking/Public'
|
|
gate: PASS
|
|
status_reason: 'Booking mutations now honor BOOKING_ENABLED and the artists grid keeps a visible static layout when animations are disabled.'
|
|
reviewer: 'Quinn (Test Architect)'
|
|
updated: '2025-09-19T22:14:00+00:00'
|
|
|
|
waiver:
|
|
active: false
|
|
|
|
top_issues: []
|
|
|
|
risk_summary:
|
|
totals: { critical: 0, high: 0, medium: 0, low: 0 }
|
|
recommendations:
|
|
must_fix: []
|
|
monitor: []
|
|
|
|
quality_score: 90
|
|
expires: '2025-10-03T22:14:00+00:00'
|
|
|
|
evidence:
|
|
tests_reviewed: 4
|
|
risks_identified: 0
|
|
trace:
|
|
ac_covered: [1, 2, 3]
|
|
ac_gaps: []
|
|
|
|
nfr_validation:
|
|
security:
|
|
status: PASS
|
|
notes: 'No new attack surface; gating is conditional boolean checks.'
|
|
performance:
|
|
status: PASS
|
|
notes: 'Guards are constant-time flag reads; fallback removes scroll listeners.'
|
|
reliability:
|
|
status: PASS
|
|
notes: 'Flag flips immediately prevent bookings and keep the home artists grid intact.'
|
|
maintainability:
|
|
status: PASS
|
|
notes: 'Guard helpers and tests cover regressions; patterns match existing flag usage.'
|
|
|
|
recommendations:
|
|
immediate: []
|
|
future:
|
|
- action: 'Consider adding an integration smoke that exercises flag flips in preview to catch environment drift.'
|
|
refs: ['docs/prd/rollback-strategy.md']
|