fix: new thread with overridden settings (#2798)

This commit is contained in:
Louis 2024-04-24 14:14:04 +07:00 committed by GitHub
parent da161cd159
commit 48f351aefd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 1 deletions

View File

@ -134,10 +134,19 @@ const DropdownListSidebar = ({
} }
if (activeThread) { if (activeThread) {
// Default setting ctx_len for the model for a better onboarding experience
// TODO: When Cortex support hardware instructions, we should remove this
const overriddenSettings =
model?.settings.ctx_len && model.settings.ctx_len > 2048
? { ctx_len: 2048 }
: {}
const modelParams = { const modelParams = {
...model?.parameters, ...model?.parameters,
...model?.settings, ...model?.settings,
...overriddenSettings,
} }
// Update model parameter to the thread state // Update model parameter to the thread state
setThreadModelParams(activeThread.id, modelParams) setThreadModelParams(activeThread.id, modelParams)

View File

@ -94,6 +94,11 @@ export const useCreateNewThread = () => {
settings: assistant.tools && assistant.tools[0].settings, settings: assistant.tools && assistant.tools[0].settings,
} }
const overriddenSettings =
defaultModel?.settings.ctx_len && defaultModel.settings.ctx_len > 2048
? { ctx_len: 2048 }
: {}
const createdAt = Date.now() const createdAt = Date.now()
const assistantInfo: ThreadAssistantInfo = { const assistantInfo: ThreadAssistantInfo = {
assistant_id: assistant.id, assistant_id: assistant.id,
@ -101,7 +106,7 @@ export const useCreateNewThread = () => {
tools: experimentalEnabled ? [assistantTools] : assistant.tools, tools: experimentalEnabled ? [assistantTools] : assistant.tools,
model: { model: {
id: defaultModel?.id ?? '*', id: defaultModel?.id ?? '*',
settings: defaultModel?.settings ?? {}, settings: { ...defaultModel?.settings, ...overriddenSettings } ?? {},
parameters: defaultModel?.parameters ?? {}, parameters: defaultModel?.parameters ?? {},
engine: defaultModel?.engine, engine: defaultModel?.engine,
}, },
@ -126,6 +131,7 @@ export const useCreateNewThread = () => {
setThreadModelParams(thread.id, { setThreadModelParams(thread.id, {
...defaultModel?.settings, ...defaultModel?.settings,
...defaultModel?.parameters, ...defaultModel?.parameters,
...overriddenSettings,
}) })
// Delete the file upload state // Delete the file upload state