CI / build-and-test (pull_request) Failing after 1m19s

Details

feat(ci,flags,ops): ship end-to-end CI, feature-flag framework, gated surfaces, and ops docs

CI (.gitea/workflows/ci.yaml): lint → typecheck → vitest w/ coverage → OpenNext build → preview smoke → bundle-size budgets; Node 20; npm ci; artifacts; safe env; D1 dry-run scaffold.

Budgets: add scripts/budgets.mjs; TOTAL_STATIC_MAX_BYTES and MAX_ASSET_BYTES thresholds; report top offenders; fail on breach; README CI section.

Flags: add lib/flags.ts with typed booleans and safe defaults (ADMIN_ENABLED, ARTISTS_MODULE_ENABLED, UPLOADS_ADMIN_ENABLED, BOOKING_ENABLED, PUBLIC_APPOINTMENT_REQUESTS_ENABLED, REFERENCE_UPLOADS_PUBLIC_ENABLED, DEPOSITS_ENABLED, PUBLIC_DB_ARTISTS_ENABLED, ADVANCED_NAV_SCROLL_ANIMATIONS_ENABLED, STRICT_CI_GATES_ENABLED, ISR_CACHE_R2_ENABLED); robust parsing; client provider; unit tests.

Wiring: gate Admin shell and admin write APIs (503 JSON on uploads and artists writes); disable booking submit and short-circuit booking mutations when off; render static Hero/Artists when advanced animations off; tests for UI and API guards.

Ops: expand docs/prd/rollback-strategy.md with “Feature Flags Operations,” Cloudflare Dashboard and wrangler.toml steps, preview simulation, incident playbook, and post-toggle smoke checklist.

Release: add docs/releases/2025-09-19-feature-flags-rollout.md with last-good commit, preview/production flag matrices, rollback notes, and smoke results; link from rollback doc.

Chore: fix TS issues (gift-cards boolean handling, Lenis options, tailwind darkMode), remove next-on-pages peer conflict, update package.json scripts, configure Gitea act_runner label, open draft PR to trigger CI.

Refs: CI-1, FF-1, FF-2, FF-3, OPS-1
Impact: defaults preserve current behavior; no runtime changes unless flags flipped

2025-09-19 21:33:09 -06:00

3.9 KiB

Raw Blame History

/qa-gate Task

When this command is used, execute the following task:

qa-gate

Create or update a quality gate decision file for a story based on review findings.

Purpose

Generate a standalone quality gate file that provides a clear pass/fail decision with actionable feedback. This gate serves as an advisory checkpoint for teams to understand quality status.

Prerequisites

Story has been reviewed (manually or via review-story task)
Review findings are available
Understanding of story requirements and implementation

Gate File Location

ALWAYS check the bmad-core/core-config.yaml for the qa.qaLocation/gates

Slug rules:

Convert to lowercase
Replace spaces with hyphens
Strip punctuation
Example: "User Auth - Login!" becomes "user-auth-login"

Minimal Required Schema

schema: 1
story: '{epic}.{story}'
gate: PASS|CONCERNS|FAIL|WAIVED
status_reason: '1-2 sentence explanation of gate decision'
reviewer: 'Quinn'
updated: '{ISO-8601 timestamp}'
top_issues: [] # Empty array if no issues
waiver: { active: false } # Only set active: true if WAIVED

Schema with Issues

schema: 1
story: '1.3'
gate: CONCERNS
status_reason: 'Missing rate limiting on auth endpoints poses security risk.'
reviewer: 'Quinn'
updated: '2025-01-12T10:15:00Z'
top_issues:
  - id: 'SEC-001'
    severity: high # ONLY: low|medium|high
    finding: 'No rate limiting on login endpoint'
    suggested_action: 'Add rate limiting middleware before production'
  - id: 'TEST-001'
    severity: medium
    finding: 'No integration tests for auth flow'
    suggested_action: 'Add integration test coverage'
waiver: { active: false }

Schema when Waived

schema: 1
story: '1.3'
gate: WAIVED
status_reason: 'Known issues accepted for MVP release.'
reviewer: 'Quinn'
updated: '2025-01-12T10:15:00Z'
top_issues:
  - id: 'PERF-001'
    severity: low
    finding: 'Dashboard loads slowly with 1000+ items'
    suggested_action: 'Implement pagination in next sprint'
waiver:
  active: true
  reason: 'MVP release - performance optimization deferred'
  approved_by: 'Product Owner'

Gate Decision Criteria

PASS

All acceptance criteria met
No high-severity issues
Test coverage meets project standards

CONCERNS

Non-blocking issues present
Should be tracked and scheduled
Can proceed with awareness

FAIL

Acceptance criteria not met
High-severity issues present
Recommend return to InProgress

WAIVED

Issues explicitly accepted
Requires approval and reason
Proceed despite known issues

Severity Scale

FIXED VALUES - NO VARIATIONS:

low: Minor issues, cosmetic problems
medium: Should fix soon, not blocking
high: Critical issues, should block release

Issue ID Prefixes

SEC-: Security issues
PERF-: Performance issues
REL-: Reliability issues
TEST-: Testing gaps
MNT-: Maintainability concerns
ARCH-: Architecture issues
DOC-: Documentation gaps
REQ-: Requirements issues

Output Requirements

ALWAYS create gate file at: qa.qaLocation/gates from bmad-core/core-config.yaml

ALWAYS append this exact format to story's QA Results section:

Gate: {STATUS} → qa.qaLocation/gates/{epic}.{story}-{slug}.yml

Keep status_reason to 1-2 sentences maximum
Use severity values exactly: low, medium, or high

Example Story Update

After creating gate file, append to story's QA Results section:

## QA Results

### Review Date: 2025-01-12

### Reviewed By: Quinn (Test Architect)

[... existing review content ...]

### Gate Status

Gate: CONCERNS → qa.qaLocation/gates/{epic}.{story}-{slug}.yml

Key Principles

Keep it minimal and predictable
Fixed severity scale (low/medium/high)
Always write to standard path
Always update story with gate reference
Clear, actionable findings

3.9 KiB Raw Blame History